[webkit-reviews] review granted: [Bug 30834] Web Inspector: Initial revision of the Timeline grid. : [Attachment 41981] [PATCH] The patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30834: Web Inspector: Initial revision of the Timeline grid.
https://bugs.webkit.org/show_bug.cgi?id=30834

Attachment 41981: [PATCH] The patch
https://bugs.webkit.org/attachment.cgi?id=41981&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +    _toggleTimelineButtonClick: function()

Better named _toggleTimelineButtonClicked.


> +	   iconElement.style.setProperty("background-position-y",
this._record.iconNumber * 12 + "px");

You should make this based on a classname.