[webkit-reviews] review denied: [Bug 30349] WebGL LayoutTests fail on buildbot : [Attachment 41976] replacement patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 30349: WebGL LayoutTests fail on buildbot
https://bugs.webkit.org/show_bug.cgi?id=30349

Attachment 41976: replacement patch
https://bugs.webkit.org/attachment.cgi?id=41976&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 50169)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,34 @@
> +2009-10-27  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +	   Make WebGL context failure more robust
> +	   https://bugs.webkit.org/show_bug.cgi?id=30349
> +
> +	   The buildbot failure has already been fixed and checked in. This

This is not a useful comment in a changelog; there isn't enough context. Just
say what the current patch is doing.

> +void CanvasRenderingContext2D::drawImage(HTMLCanvasElement* passedCanvas,
const FloatRect& srcRect,

passedCanvas is vague. Is it the source or the destination?


> Index: WebCore/html/canvas/CanvasRenderingContext3D.cpp
> ===================================================================
> --- WebCore/html/canvas/CanvasRenderingContext3D.cpp	(revision 50115)
> +++ WebCore/html/canvas/CanvasRenderingContext3D.cpp	(working copy)
> @@ -42,12 +42,23 @@
>  
>  namespace WebCore {
>  
> -CanvasRenderingContext3D::CanvasRenderingContext3D(HTMLCanvasElement*
canvas)
> -    : CanvasRenderingContext(canvas)
> +CanvasRenderingContext3D*
CanvasRenderingContext3D::create(HTMLCanvasElement* canvas)

Darin said:
> This function should return a PassOwnPtr<CanvasRenderingContext3D>.