[webkit-reviews] review granted: [Bug 30709] Web Inspector: Pretty Print all HTML Collection Types like we do for NodeList : [Attachment 41974] [PATCH+TEST] Pretty Print Known HTMLCollections (with runAfterTimeouts)

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 30709: Web Inspector: Pretty Print all HTML Collection Types like we do for
NodeList
https://bugs.webkit.org/show_bug.cgi?id=30709

Attachment 41974: [PATCH+TEST] Pretty Print Known HTMLCollections (with
runAfterTimeouts)
https://bugs.webkit.org/attachment.cgi?id=41974&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    this.timeouts = 0;

How about this.pendingDispatches?


> +WebInspector.runAfterTimeouts = function(cb)

And runAfterPendingDispatches?


> +{
> +    if (WebInspector.timeouts === 0)
> +	   cb();
> +    else
> +	   setTimeout(WebInspector.runAfterTimeouts, 0, cb);
> +}

cb should be callback. And this syntax looks better to me, but your way is
shorten so I fold.

if (!WebInspector.pendingDispatches) {
    callback();
    return;
}

setTimeout(WebInspector.runAfterPendingDispatches, 0, callback);