[webkit-reviews] review requested: [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface : [Attachment 41965] table 3 - corrected as per review
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 27 10:40:49 PDT 2009
Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked for review:
Bug 25534: [GTK] Objects of ROLE_TABLE should implement the accessible table
interface
https://bugs.webkit.org/show_bug.cgi?id=25534
Attachment 41965: table 3 - corrected as per review
https://bugs.webkit.org/attachment.cgi?id=41965&action=review
------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
> I think it's better to do a if (!object)\nreturn 0; at the beginning here.
Done.
> Same comment about NULL than in the other patches (sorry about that!).
Done. No need to apologize. I need to re-read the style guide until it becomes
second nature.
Thanks for the review!
More information about the webkit-reviews
mailing list