[webkit-reviews] review granted: [Bug 30548] Remove the dependency on OriginQuotaManager from Database.cpp : [Attachment 41917] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 09:04:12 PDT 2009


Adam Barth <abarth at webkit.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 30548: Remove the dependency on OriginQuotaManager from Database.cpp
https://bugs.webkit.org/show_bug.cgi?id=30548

Attachment 41917: patch
https://bugs.webkit.org/attachment.cgi?id=41917&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
In DatabaseTracker::getMaxSizeForDatabase, do we need to addref the origin?

+ RefPtr<SecurityOrigin> origin = database->securityOrigin();

It seems like we can use a raw pointer here and avoid the churning the ref
count.


More information about the webkit-reviews mailing list