[webkit-reviews] review requested: [Bug 27147] JS Syntax Highlight is incorrect for keyword followed by string or regexp : [Attachment 41953] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 08:03:53 PDT 2009


Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27147: JS Syntax Highlight is incorrect for keyword followed by string or
regexp
https://bugs.webkit.org/show_bug.cgi?id=27147

Attachment 41953: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41953&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
> You should write some more tests that are multi-line and deal with things
like
> message bubbles and nodes directly.

I added some multiline tests. 
I tried to write a message bubble test like this
http://gist.github.com/219610
But I get the timeout error. The event doesn't seem to be getting dispatched
but I couldn't figure out more.


More information about the webkit-reviews mailing list