[webkit-reviews] review denied: [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface : [Attachment 41924] table 3

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has denied Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25534: [GTK] Objects of ROLE_TABLE should implement the accessible table
interface
https://bugs.webkit.org/show_bug.cgi?id=25534

Attachment 41924: table 3
https://bugs.webkit.org/attachment.cgi?id=41924&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+static const gchar* nameFromChildren(AccessibilityObject* object)
>+{
>+    if (object) {
>+	  AccessibilityRenderObject::AccessibilityChildrenVector children =
object->children();
>+	  // Currently, object->stringValue() should be an empty String. This
>+	  // might not be the case down the road.
>+	  String name = object->stringValue();
>+	  for (unsigned i = 0; i < children.size(); ++i)
>+	      name += children.at(i).get()->stringValue();
>+	  return returnString(name);
>+    }
>+
>+    return NULL;

I think it's better to do a if (!object)\nreturn 0; at the beginning here.

>+static AtkObject* webkit_accessible_table_get_column_header(AtkTable* table,
gint column)
>+{
>+    // FIXME: This needs to be implemented.
>+    notImplemented();
>+    return NULL;
>+}

Same comment about NULL than in the other patches (sorry about that!).

r- for now, let's fix those two things.