[webkit-reviews] review granted: [Bug 25534] [GTK] Objects of ROLE_TABLE should implement the accessible table interface : [Attachment 41898] table 1 (breaking these apart for easier review)

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25534: [GTK] Objects of ROLE_TABLE should implement the accessible table
interface
https://bugs.webkit.org/show_bug.cgi?id=25534

Attachment 41898: table 1 (breaking these apart for easier review)
https://bugs.webkit.org/attachment.cgi?id=41898&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>+static gint cellIndex(AccessibilityTableCell* AXCell, AccessibilityTable*
AXTable)
>+{
>+    // Calculate the cell's index as if we had a traditional Gtk+ table in
>+    // which cells are all direct children of the table, arranged row-first.
>+    //

No need for that empty comment line.

>+    AccessibilityObject::AccessibilityChildrenVector allCells;
>+    AXTable->cells(allCells);
>+    AccessibilityObject::AccessibilityChildrenVector::iterator position;
>+    position = std::find(allCells.begin(), allCells.end(), AXCell);
>+    if (position == allCells.end())
>+	  return -1;
>+    return position - allCells.begin();
>+}
>+
>+static AtkObject* webkit_accessible_table_ref_at(AtkTable* table, gint row,
gint column)
>+{
>+    AccessibilityTableCell* AXCell = cell(table, row, column);
>+    if (!AXCell)
>+	  return NULL;

In theory we try to use '0' instead of 'NULL' (per WebKit style guide), but I
realize this file is a mess wrt that.

>+    return AXCell->wrapper();
>+}
>+

I'll land this fixing those small details, thanks!