[webkit-reviews] review granted: [Bug 30786] Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned off and refactor some related code : [Attachment 41889] proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 21:34:05 PDT 2009
Antti Koivisto <koivisto at iki.fi> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 30786: Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned
off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786
Attachment 41889: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41889&action=review
------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Ok. As a cleaner alternative, you could eliminate the need for WIN_OS ifdef by
giving PlatformModuleVersion struct the inequality and comparison operator.
But it is not that important r=me in any case.
More information about the webkit-reviews
mailing list