[webkit-reviews] review requested: [Bug 30491] Pressing Enter in <isindex> doesn't submit it if there is no form : [Attachment 41918] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 17:33:22 PDT 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30491: Pressing Enter in <isindex> doesn't submit it if there is no form
https://bugs.webkit.org/show_bug.cgi?id=30491

Attachment 41918: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=41918&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Updated patch based on Darin's suggestions.

I decided to define a no-argument method called
HTMLInputElement::createTemporaryFormForIsIndex as opposed to something more
generalized (like createTemporaryForm as Darin suggested) because only the
<isindex> element needs to create a temporary form and this form must always
register the form element we are in (i.e. this) plus possibly use the base href
URL as the form action (which is very <isindex>-specific functionality).


More information about the webkit-reviews mailing list