[webkit-reviews] review denied: [Bug 30681] Symbian port: JS Date operations very slow due to flaky POSIX date/time implementation : [Attachment 41679] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 16:17:08 PDT 2009


Antti Koivisto <koivisto at iki.fi> has denied Siddharth Mathur
<siddharth.mathur at nokia.com>'s request for review:
Bug 30681: Symbian port: JS Date operations very slow due to flaky POSIX
date/time implementation
https://bugs.webkit.org/show_bug.cgi?id=30681

Attachment 41679: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41679&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Right, seems that this would trivially break getUTCOffset() by making it
include DST correction. Not all callpaths automatically add the DST offset
later.

If Qt has better implementation, you could just switch to those (from the posix
ones, with appropriate ifdefs).


More information about the webkit-reviews mailing list