[webkit-reviews] review denied: [Bug 29443] [Qt] WebKit crashes when loading certain SVG images : [Attachment 41569] Patch with test case

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Benjamin Poulain
<benjamin.poulain at nokia.com>'s request for review:
Bug 29443: [Qt] WebKit crashes when loading certain SVG images
https://bugs.webkit.org/show_bug.cgi?id=29443

Attachment 41569: Patch with test case
https://bugs.webkit.org/attachment.cgi?id=41569&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems svg/text/resources/text-font-invalid.svg could be dumpAsText.	It's
just a crash test, no?	It also should have some sort of <text>PASSED -- this
test did not crash</text>

Unintentional change?
WebCore/platform/graphics/qt/FontPlatformData.h

1  /*
 1   /*


Is this what you want?
80     unsigned hash() const
 81	{
 82	    return qHash(m_font.toString());
 83	}

Does that correctly handle smallCaps and italic, etc?

I'm not convinced that hash() and == are equivalent.  If they are not, that
could cause badness!

In general this looks fine though.