[webkit-reviews] review requested: [Bug 30786] Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned off and refactor some related code : [Attachment 41889] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 13:53:36 PDT 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 30786: Fix QtWebKit build for WIN_OS if Netscape plug-in support is turned
off and refactor some related code
https://bugs.webkit.org/show_bug.cgi?id=30786

Attachment 41889: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41889&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
* platform/FileSystem.h: Refactor to make sure that each different type
definition is only repeated once.

* plugins/PluginPackage.cpp: (WebCore::PluginPackage::compareFileVersion): Move
it out from the ENABLE_PLUGIN_PACKAGE_SIMPLE_HASH guard and combine it with the
version from PluginPackageWin.

* plugins/win/PluginPackageWin.cpp: Remove compareFileVersion as it is now in
PluginPackage.cpp.


More information about the webkit-reviews mailing list