[webkit-reviews] review requested: [Bug 30678] Database thread initialization not properly ifdef'ed for JSC vs V8 : [Attachment 41878] Patch 3 for Bug 30678

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has asked  for review:
Bug 30678: Database thread initialization not properly ifdef'ed for JSC vs V8
https://bugs.webkit.org/show_bug.cgi?id=30678

Attachment 41878: Patch 3 for Bug 30678
https://bugs.webkit.org/attachment.cgi?id=41878&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> (From update of attachment 41730 [details])
> +    // Darwin is an exception to this rule: it is OK to call this function
> from any thread, even reentrantly.
>
> The code does not back that up.  The JSC version has no reentrancy guard, but

> the V8 one does.  That seems to have little to do with darwin vs. non-darwin.

You're right that the comment about Darwin on V8 is wrong - that was a
copy-paste error - now fixed.

The comment for the JSC version is taken from JSC::initializeThreading() in
JavaScriptCore/runtime/InitializeThreading.h, so should be correct. The
implementation of ScriptController::initializeThreading() for V8 is the same as
the logic in JSC::initializeThreading() (less the Darwin and JSC specifics).
Both guard against repeated calls to the function.