[webkit-reviews] review requested: [Bug 25897] [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries : [Attachment 41877] Add ability for platforms to ignore objects

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25897: [Gtk] Extraneous object of ROLE_PANEL in hierarchy for entries
https://bugs.webkit.org/show_bug.cgi?id=25897

Attachment 41877: Add ability for platforms to ignore objects
https://bugs.webkit.org/attachment.cgi?id=41877&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
Expands on -- and modifies -- what was done to fix bug 27085. Now platforms can
indicate that they:

* Want to include an object (i.e. one which accessibilityIsIgnored()
  would otherwise ignore, aka bug 27085)

* Want to ignore an object (i.e. one which accessibilityIsIgnored()
  would include, aka this bug)

* Want to let accessibilityIsIgnored() decide.

What I like:

* More control at the platform level to deal with unique needs/issues.

* Fixes both of the issues in question.

What I don't like much:

* The names. Y'all decide what they should be, and I will make it so. :-)

Also, Xan: I narrowed the logic down from your pastebin patch to just look at
text-based controls. Looking at all controls seems like it might accidentally
cause us to ignore parts of the hierarchy of certain funky widgets I've seen in
Aria, Dojo, etc. And maybe even combo boxes -- which I still have to implement,
but which have hierarchies like:

-> combo box
   -> menu
      -> menu item
      -> menu item

Anyhoo.... Thoughts?