[webkit-reviews] review denied: [Bug 30776] Web Inspector: Extract AbstractTimelinePanel that will be a base class for ResourcesPanel and TimelinePanel. : [Attachment 41868] [PATCH] Step 1 that might need follow up.

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30776: Web Inspector: Extract AbstractTimelinePanel that will be a base
class for ResourcesPanel and TimelinePanel.
https://bugs.webkit.org/show_bug.cgi?id=30776

Attachment 41868: [PATCH] Step 1 that might need follow up.
https://bugs.webkit.org/attachment.cgi?id=41868&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
There are a few mentions of "resources" in AbstractTimelinePanel, mostly in
classes and node ids.

I think createTimelinePanels would be better named "createInterface",
createTimelinePanels confused me since I thought it was creating the panels.

Will the scope bar live in AbstractTimelinePanel but just not be used by
TimelinePanel?

The scope bar code needes merged with SVN, there have been some changes to
support Command-Clicking.

Any "create" function that only gets called internal to one class should have a
underscore prefix. (Like createStatusbarButtons.)

r- since it needs merged with SVN first to get scope bar changes.