[webkit-reviews] review requested: [Bug 30771] [Qt] Make qwebpage's createWindow not qwebview dependent : [Attachment 41862] patch 0.1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 06:18:37 PDT 2009


Antonio Gomes (tonikitoo) <tonikitoo at webkit.org> has asked  for review:
Bug 30771: [Qt] Make qwebpage's createWindow not qwebview dependent
https://bugs.webkit.org/show_bug.cgi?id=30771

Attachment 41862: patch 0.1
https://bugs.webkit.org/attachment.cgi?id=41862&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at webkit.org>
Patch does:

1) makes qwebpage::createWindow widget independent (pageClient used now).
2) adds a pure virtual createWindow method to qwebpageclient.
3) fixes some minor nits ("*" position and such)


More information about the webkit-reviews mailing list