[webkit-reviews] review requested: [Bug 30767] [Qt] Reintroduce QWebElementCollection : [Attachment 41858] Path to replace QList<QWebElement> by QWebElementCollection
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 03:53:51 PDT 2009
Benjamin Poulain <benjamin.poulain at nokia.com> has asked for review:
Bug 30767: [Qt] Reintroduce QWebElementCollection
https://bugs.webkit.org/show_bug.cgi?id=30767
Attachment 41858: Path to replace QList<QWebElement> by QWebElementCollection
https://bugs.webkit.org/attachment.cgi?id=41858&action=review
------- Additional Comments from Benjamin Poulain <benjamin.poulain at nokia.com>
This patch basically revert the commit 42994
(e4ed760783109673896551892c029dc043c70b71 on git).
The changes from the original patch are:
-QWebElement operator[] do not return a const QWebElement anymore to be
coherent with the previous use of QList
-The new tests had to be adapted.
If the idea is accepted and we reintroduce QWebElementCollection, a new bug
should be created in the tree 29843 to review the API of QWebElementCollection.
More information about the webkit-reviews
mailing list