[webkit-reviews] review granted: [Bug 29506] PrettyPatch should show images even when they have the wrong mime type : [Attachment 41760] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Oct 25 08:32:28 PDT 2009


Adam Roben (aroben) <aroben at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 29506: PrettyPatch should show images even when they have the wrong mime
type
https://bugs.webkit.org/show_bug.cgi?id=29506

Attachment 41760: Patch v1
https://bugs.webkit.org/attachment.cgi?id=41760&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It seems a little strange for has_image_suffix to be an instance method of the
FileDiff class. It would probably be better as a method of String or just in
the private section of the PrettyPatch module.

r=me


More information about the webkit-reviews mailing list