[webkit-reviews] review requested: [Bug 30491] Pressing Enter in <isindex> doesn't submit it if there is no form : [Attachment 41814] Patch with test cases

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Oct 24 22:40:24 PDT 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 30491: Pressing Enter in <isindex> doesn't submit it if there is no form
https://bugs.webkit.org/show_bug.cgi?id=30491

Attachment 41814: Patch with test cases
https://bugs.webkit.org/attachment.cgi?id=41814&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Moved code into HTMLInputElement::defaultEventHandler so that we don't create a
form that is visible to the client. Hence, we conform to
http://www.w3.org/TR/1998/REC-DOM-Level-1-19981001/level-one-html#ID-87069980.

I am open to suggestions on the placement of this code. Also, let me know if
you have a better name for the variable myForm.

This patch passes all layout tests, on my Mac, as of r49810.


More information about the webkit-reviews mailing list