[webkit-reviews] review denied: [Bug 30324] Console shows no repeat count when repeatedly logging an Event : [Attachment 41789] proposed patch 3

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 30324: Console shows no repeat count when repeatedly logging an Event
https://bugs.webkit.org/show_bug.cgi?id=30324

Attachment 41789: proposed patch 3
https://bugs.webkit.org/attachment.cgi?id=41789&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Looks good. Couple of nits, otherwise r+.

> +	       msgCopy = new WebInspector.ConsoleMessage(msg.source, msg.type,
msg.level, msg.line, msg.url, msg.groupLevel, count - prevRepeatCount);

You should either use this.repeatCountBeforeCommand here or remove it since it
is no more used.

> +    incrementErrorWarningCount: function(msg) {

Please use _incrementErrorWarningCount as this is private method.


> +    updateRepeatCount: function() {

Also private


> -    toMessageElement: function()
> +    get element()

(No need to fix): Why rename? Since this code below is kinda ugly:

> +	   this._element =
WebInspector.ConsoleMessage.prototype.__lookupGetter__("element").call(this);