[webkit-reviews] review granted: [Bug 28186] Web Inspector scope bar not quite right : [Attachment 41799] Proposed Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Timothy Hatcher <timothy at hatcher.name>'s request
for review:
Bug 28186: Web Inspector scope bar not quite right
https://bugs.webkit.org/show_bug.cgi?id=28186

Attachment 41799: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=41799&action=review

------- Additional Comments from mitz at webkit.org
> -#console-filter div.divider, #resources-filter div.divider {
> -    margin-left: 5px;
> -    margin-right: 5px;
> -    /* Only want a border-left here because border on both sides
> -    made the divider too thick */
> -    border-left: 1px solid gray;
> -    display: inline;
> +.scope-bar .divider {
> +    margin: 1px 9px 0 8px;
> +    border-left: 1px solid rgba(0, 0, 0, 0.4);
> +    height: 16px;
> +    width: 0;
> +    vertical-align: middle;
> +    display: inline-block;
>  }

Now that this element is an inline block, I think it would be better to just
give it 1px width and a background-color instead of 0 width and a 1px border.