[webkit-reviews] review denied: [Bug 30548] Remove the dependency on OriginQuotaManager from Database.cpp : [Attachment 41471] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 30548: Remove the dependency on OriginQuotaManager from Database.cpp
https://bugs.webkit.org/show_bug.cgi?id=30548

Attachment 41471: patch
https://bugs.webkit.org/attachment.cgi?id=41471&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks reasonable.  A few minor points about RefPtrs:

+ PassRefPtr<SecurityOrigin> Database::databaseThreadSecurityOrigin() const
+ PassRefPtr<SecurityOrigin> Database::threadSafeSecurityOrigin() const

No need to use a PassRefPtr here because we're not transferring ownership.  We
can just use a raw ptr.  For more information, please see
http://webkit.org/coding/RefPtr.html

+ RefPtr<SecurityOrigin> origin = database->databaseThreadSecurityOrigin();

No need to churn ref counter here.  |database| will keep origin alive for you
during this call.