[webkit-reviews] review granted: [Bug 30619] [Linux] Menu key doesn't work : [Attachment 41655] Hi, I added a manual test and also updated platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended eventSender.keyDown() for now.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Oct 24 03:45:19 PDT 2009
Jan Alonzo <jmalonzo at gmail.com> has granted Kinuko Yasuda <kinuko at google.com>'s
request for review:
Bug 30619: [Linux] Menu key doesn't work
https://bugs.webkit.org/show_bug.cgi?id=30619
Attachment 41655: Hi, I added a manual test and also updated
platform/gtk/KeyEventGtk.cpp. In this patch I haven't extended
eventSender.keyDown() for now.
https://bugs.webkit.org/attachment.cgi?id=41655&action=review
------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> + No new tests: testing this will require changes in the test
> + controller in a platform-specific way. (Mac doesn't have Menu key)
Would be nice to mention that there's a manual test for this.
Regardles, LGTM. r=me.
More information about the webkit-reviews
mailing list