[webkit-reviews] review granted: [Bug 30707] WebInspector: Refactors InspectorTimelineAgent to eliminate TimelineItem classes : [Attachment 41761] Addresses issues raised by pfeldman.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Oct 23 16:19:44 PDT 2009
Pavel Feldman <pfeldman at chromium.org> has granted Kelly Norton
<knorton at google.com>'s request for review:
Bug 30707: WebInspector: Refactors InspectorTimelineAgent to eliminate
TimelineItem classes
https://bugs.webkit.org/show_bug.cgi?id=30707
Attachment 41761: Addresses issues raised by pfeldman.
https://bugs.webkit.org/attachment.cgi?id=41761&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Couple of nits that can be addressed in further patches.
+ TimelineItemEntry entry = m_itemStack.last();
ASSERT(m_itemStack.size()); ?
+ if (m_itemStack.isEmpty()) {
no { here
More information about the webkit-reviews
mailing list