[webkit-reviews] review granted: [Bug 30725] Web Inspector: Implement a Timeline panel : [Attachment 41757] [PATCH] Add panel

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 16:10:16 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 30725: Web Inspector: Implement a Timeline panel
https://bugs.webkit.org/show_bug.cgi?id=30725

Attachment 41757: [PATCH] Add panel
https://bugs.webkit.org/attachment.cgi?id=41757&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	       this._itemTypeNames[itemTypes.RecalculateStyles] =
WebInspector.UIString("Recalc Style");

Can we just have the UIString be "Recalculate Style"? I hate abbrivations in UI
strings. I also would just lump it under Layout at a high level, but
indiviually label it Recalculate Style.


>	   }
> +	   // Uncomment this when timeline is ready.

Add a newline between these lines.


More information about the webkit-reviews mailing list