[webkit-reviews] review granted: [Bug 30700] fast/media/mq-transform-02.html failed on Leopard Commit Bot : [Attachment 41737] update qtVersion check

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 11:47:03 PDT 2009


Eric Carlson <eric.carlson at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 30700: fast/media/mq-transform-02.html failed on Leopard Commit Bot
https://bugs.webkit.org/show_bug.cgi?id=30700

Attachment 41737: update qtVersion check
https://bugs.webkit.org/attachment.cgi?id=41737&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
> -    // Bug 7228836 exists in at least 7.6.3 and 7.6.4, hopefully it will be
fixed in 7.6.5.
> +    // Bug 7228836 exists in at least 7.6.3 through 7.6.4.8, hopefully it
will be fixed in 7.6.5.

This comment is incorrect. The version is encoded in BCD where the third byte
is the "release stage", and 80 indicates the final release (see
http://developer.apple.com/mac/library/technotes/tn/tn1132.html).

r=me with a fixed comment


More information about the webkit-reviews mailing list