[webkit-reviews] review denied: [Bug 30719] Fix the Chromium build after IsloatedWorld change (r49963) : [Attachment 41734] Patch v1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Tony Chang (Google)
<tony at chromium.org>'s request for review:
Bug 30719: Fix the Chromium build after IsloatedWorld change (r49963)
https://bugs.webkit.org/show_bug.cgi?id=30719

Attachment 41734: Patch v1
https://bugs.webkit.org/attachment.cgi?id=41734&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebCore/bindings/v8/ScriptController.cpp
b/WebCore/bindings/v8/ScriptController.cpp

> +// FIXME

Would be nice to say what is to be fixed.

> +DOMWrapperWorld* mainThreadNormalWorld()
> +{
> +    return 0;
> +}


> diff --git a/WebCore/bindings/v8/ScriptController.h
b/WebCore/bindings/v8/ScriptController.h

> +    // FIXME: Stub method so we compile.  Currently called from
> +    // FrameLoader.cpp.
> +    DOMWrapperWorld* mainThreadNormalWorld();

Why not move this comment inside of the cpp file and just not have it here?
(Is there anything to fix with the prototype?)


> diff --git a/WebCore/dom/Document.cpp b/WebCore/dom/Document.cpp
> +#if USE(JSC)
>      world->rememberDocument(this);
Can this method be implemented (to do nothing) for V8 and then remove this
ifdef in the code?

> +#endif