[webkit-reviews] review denied: [Bug 30716] Fix Chromium build errors in WebCore : [Attachment 41728] patch 1

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 30716: Fix Chromium build errors in WebCore
https://bugs.webkit.org/show_bug.cgi?id=30716

Attachment 41728: patch 1
https://bugs.webkit.org/attachment.cgi?id=41728&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Nice. Just one thing to be addressed.

> Index: WebCore/rendering/RenderMediaControlsChromium.cpp
>      case MediaCurrentTimePart:
>      case MediaTimeRemainingPart:
>	   return true;
> +    default:
> +	   ;

The missing enum value(s) should be added to the switch (not a default: which
hides the fact that values aren't being handled).

> @@ -272,6 +274,8 @@ bool RenderMediaControlsChromium::paintM
>      case MediaControlsPanel:
>	   ASSERT_NOT_REACHED();
>	   break;
> +    default:
> +	   ;

The missing enum value(s) should be added to the switch (not a default: which
hides the fact that values aren't being handled).