[webkit-reviews] review granted: [Bug 30365] empty optgroup crashes browser upon form submit : [Attachment 41693] Crash fix and a layout test for it.

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Rahul Kuchhal
<kuchhal at chromium.org>'s request for review:
Bug 30365: empty optgroup crashes browser upon form submit
https://bugs.webkit.org/show_bug.cgi?id=30365

Attachment 41693: Crash fix and a layout test for it.
https://bugs.webkit.org/attachment.cgi?id=41693&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	https://bugs.webkit.org/show_bug.cgi?id=30365

Tab here, please use spaces.

The comment above the code that you modified is misguiding - as we now know,
this case can legitimately happen if the select only contains optgroup
children. And the comment doesn't suggest any criteria to verify if it's still
relevant - maybe we have already fixed that? The comment should mention the
case with optgroups, and then say that this should be the only such case. Maybe
you could add an assertion to this effect and run layout tests to check if the
assertion is hit.

r=me as is, with only the tab fixed, but this code could benefit from a little
more attention.