[webkit-reviews] review requested: [Bug 30660] WebInspector: Can't use IME inside console : [Attachment 41707] proposed patch 2

[bugzilla-daemon at webkit.org]

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 30660: WebInspector: Can't use IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Attachment 41707: proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=41707&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
>
http://trac.webkit.org/browser/trunk/WebCore/inspector/front-end/ElementsTreeOu
tline.js?rev=49709#L202
I don't think we need to check here because we can't be in IME. We only need to
check if we want to detect an Enter key while the user is typing text.

Turns out that keyup doesn't return keycode=229 and we can't tell if we are in
an IME or not. So I moved performSearch() to searchKeyDown.

The comment says that "Only call performSearch if the Enter key was pressed."
but I think we are doing incremental search. 
Is this a regression? Or is the comment old?