[webkit-reviews] review requested: [Bug 25530] [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels : [Attachment 41689] implment relationship pair and set the name

[bugzilla-daemon at webkit.org]

Joanmarie Diggs <joanmarie.diggs at gmail.com> has asked  for review:
Bug 25530: [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels
https://bugs.webkit.org/show_bug.cgi?id=25530

Attachment 41689: implment relationship pair and set the name
https://bugs.webkit.org/attachment.cgi?id=41689&action=review

------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
(In reply to comment #13)
> > CCing cfleizach at apple.com, which was in the past our a11y contact: can you
look
> > at the last patch in the attachment list and see if you are OK with the two

> > functions added to AccessibilityRenderObject?
> 
> So there's already a 
> correspondingControlForLabelElement

Yikes. I totally missed that somehow. My apologies.

This patch uses it.
 
> Otherwise, i'm OK having a pair to find label/control control/label pairs

Awesome. Thanks. labelForCorrespondingControlElement added.

This also solves the issue of setting the name, which I mentioned having
problems with.

Xan, please review. Thanks!