[webkit-reviews] review requested: [Bug 30663] Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive" : [Attachment 41680] [PATCH] Handle Focus/Blur of inner <iframe>s

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 22 13:35:58 PDT 2009


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 30663: Web Inspector: windowFocused and windowBlured Fail to Clear/Mark
Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

Attachment 41680: [PATCH] Handle Focus/Blur of inner <iframe>s
https://bugs.webkit.org/attachment.cgi?id=41680&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Because focus/blur do not tell you _what_ they are focusing on there has to be
a bit of co-dependence between the focus/blur:

- Blur runs first, if you're blurring any inner document, always add "inactive"

- Focus runs next, if you're focusing on any inner document, remove "inactive"

Changing useCapture to false no longer fires duplicate blur/focus events.  This
was happening when clicking a toolbar (when they were in their :active state).
Could be a bug in itself, and may require some investigation.


More information about the webkit-reviews mailing list