[webkit-reviews] review denied: [Bug 23846] [GTK]Enable DNS prefetching : [Attachment 41664] DNS Prefetch patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied José Millán Soto
<jmillan at igalia.com>'s request for review:
Bug 23846: [GTK]Enable DNS prefetching
https://bugs.webkit.org/show_bug.cgi?id=23846

Attachment 41664: DNS Prefetch patch
https://bugs.webkit.org/attachment.cgi?id=41664&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
There are several style problems here.	Did you try running check-webkit-style?


Two here:
+static bool checkPrefetched(const String &hostname) {

Two more here:
+    if (hostname.isEmpty()) return;
+    if (checkPrefetched(hostname)) return;

Here:
+    /*
+	 This may work while soup_session_prepare_for_uri is not avaliable
+    */

no wrapping rules in webkit:
+    SoupAddress* address = soup_address_new(hostname.utf8().data(),
+			     SOUP_ADDRESS_ANY_PORT);