[webkit-reviews] review denied: [Bug 30660] WebInspector: Can't use IME inside console : [Attachment 41635] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 22 07:37:08 PDT 2009


Pavel Feldman <pfeldman at chromium.org> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 30660: WebInspector: Can't use IME inside console
https://bugs.webkit.org/show_bug.cgi?id=30660

Attachment 41635: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41635&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +		   if (event.keyCode !== 229) {
> +		       this._enterKeyPressed(event);

229 all over the place is a bit confusing. Maybe you could add something like

function isEnterKey(event) {
    // Check if in IME.
    return event.keyCode !== 229 && event.keyIdentifier === "Enter";
}

into the utilities.js?


More information about the webkit-reviews mailing list