[webkit-reviews] review denied: [Bug 30661] Chromium HTTP Connection Count erroneously throttled to 4. : [Attachment 41641] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 22 06:28:36 PDT 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Mike Belshe
<mike at belshe.com>'s request for review:
Bug 30661: Chromium HTTP Connection Count erroneously throttled to 4.
https://bugs.webkit.org/show_bug.cgi?id=30661
Attachment 41641: patch
https://bugs.webkit.org/attachment.cgi?id=41641&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> + Make the number of connections for chromium controlled by
> + chromium rather than by ReosurceRequestBase.
> + https://bugs.webkit.org/show_bug.cgi?id=30661
nit: ^^^ remove the tabs
> Index: WebCore/platform/network/ResourceRequestBase.cpp
...
> +#if !PLATFORM(MAC) && !USE(CFNETWORK) && !USE(SOUP) && !PLATFORM(CHROMIUM)
> unsigned initializeMaximumHTTPConnectionCountPerHost()
This method should probably be implemented in chromium/ResourceRequest.h as
either defined to return 6 or defined in terms of a ChromiumBridge function
call of exactly the same signature.
More information about the webkit-reviews
mailing list