[webkit-reviews] review denied: [Bug 30670] [Qt] symbian buildfix for resourceloadnotifier : [Attachment 41654] proposed fix for ResourceLoaderNotifier.h take 2

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Janne Koskinen
<koshuin at gmail.com>'s request for review:
Bug 30670: [Qt] symbian buildfix for resourceloadnotifier
https://bugs.webkit.org/show_bug.cgi?id=30670

Attachment 41654: proposed fix for ResourceLoaderNotifier.h take 2
https://bugs.webkit.org/attachment.cgi?id=41654&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  #include <wtf/Noncopyable.h>
> -

^^^ we don't add whitespace like this...


>  namespace WebCore {
>  
>  class AuthenticationChallenge;
> @@ -40,7 +39,7 @@ class Frame;
>  class ResourceError;
>  class ResourceLoader;
>  class ResourceResponse;
> -class ResourceRequest;
> +struct ResourceRequest;
>  class ScriptString;


Yes and No. CF, Chromium, CURL, SOUP refer to it as struct ResourceRequest, mac
is having a proper class.

WebCore/platform/network/mac/ResourceRequest.h:41:    class ResourceRequest :
public ResourceRequestBase {

I think it is time to change the other ports to class ResourceRequest as well
because the base class is declared as a "class".