[webkit-reviews] review denied: [Bug 29803] [Qt] QWebHistory and QWebPage autotests crash : [Attachment 41649] patch

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied jedrzej.nowacki at nokia.com's
request for review:
Bug 29803: [Qt] QWebHistory and QWebPage autotests crash
https://bugs.webkit.org/show_bug.cgi?id=29803

Attachment 41649: patch
https://bugs.webkit.org/attachment.cgi?id=41649&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>      frameLoaderClient->setFrame(qframe, frame);
> -
>      frame->init();
> +    // Delay the signal QWebPage::frameCreated(QWebFrame*), because the
QwebPage might be not
> +    // fully created (no way to connect to the signal).

Whitespace, spelling... QwebPage vs. QWebPage..



> +	   Emission of the frameCreated signal was moved to the
QWebFrame::init()
> +	   and delayed.

I didn't read most of the bug report. The ChangeLog should answer the question
why? The QWebPage pretty much knows when the mainFrame got created? Why do we
need to delay this signal?