[webkit-reviews] review requested: [Bug 30663] Web Inspector: windowFocused and windowBlured Fail to Clear/Mark Inspector as "inactive" : [Attachment 41639] [PATCH] Check document.defaultView

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 23:24:21 PDT 2009


Joseph Pecoraro <joepeck at webkit.org> has asked	for review:
Bug 30663: Web Inspector: windowFocused and windowBlured Fail to Clear/Mark
Inspector as "inactive"
https://bugs.webkit.org/show_bug.cgi?id=30663

Attachment 41639: [PATCH] Check document.defaultView
https://bugs.webkit.org/attachment.cgi?id=41639&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
The events are registered on a doc.defaultView:

  doc.defaultView.addEventListener("focus", this.windowFocused.bind(this),
true);
  doc.defaultView.addEventListener("blur", this.windowBlured.bind(this), true);


The doc.defaultView is a DOMWindow. Old behavior always fails:

  if (event.target.nodeType === Node.DOCUMENT_NODE)

New behavior tests against the defaultView:

  if (event.target === document.defaultView)


More information about the webkit-reviews mailing list