[webkit-reviews] review denied: [Bug 19135] console.assert should prefix messages with "Assertion failed: " : [Attachment 41632] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 20:25:25 PDT 2009


Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19135: console.assert should prefix messages with "Assertion failed: "
https://bugs.webkit.org/show_bug.cgi?id=19135

Attachment 41632: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41632&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	      
messageTextElement.appendChild(document.createTextNode("Assertion failed: "));

This sting needs to be localizable. WebInspector.UIString and added
LocalizableStrings.js.


More information about the webkit-reviews mailing list