[webkit-reviews] review granted: [Bug 30522] Web Inspector: DOM Exceptions throughout the Inspector should be more human readable : [Attachment 41609] Patch w/ Better Test - Addresses Eric's Comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 14:36:53 PDT 2009


Eric Seidel <eric at webkit.org> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 30522: Web Inspector: DOM Exceptions throughout the Inspector should be
more human readable
https://bugs.webkit.org/show_bug.cgi?id=30522

Attachment 41609: Patch w/ Better Test - Addresses Eric's Comments
https://bugs.webkit.org/attachment.cgi?id=41609&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You could use:
shouldBeEqualToString("e.name", "NOT_FOUND_ERR")
to make parts of the test self-documenting.

Obviously the description stuff might vary more between browsers and you may
want to leave as just "debug()"

The change looks OK as is, but using shouldBe or shouldBeEqualToString would be
nicer.


More information about the webkit-reviews mailing list