[webkit-reviews] review canceled: [Bug 25530] [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels : [Attachment 41386] patch to implement the relationship pair - take 1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 21 12:02:02 PDT 2009
Joanmarie Diggs <joanmarie.diggs at gmail.com> has canceled Joanmarie Diggs
<joanmarie.diggs at gmail.com>'s request for review:
Bug 25530: [Gtk] Implement LABEL_FOR/LABELLED_BY relationship pair for labels
https://bugs.webkit.org/show_bug.cgi?id=25530
Attachment 41386: patch to implement the relationship pair - take 1
https://bugs.webkit.org/attachment.cgi?id=41386&action=review
------- Additional Comments from Joanmarie Diggs <joanmarie.diggs at gmail.com>
> > Current: labeledBy()
> > Proposed: getLabelForControl()
> >
> > Current: labelFor()
> > Proposed: getControlForLabel()
>
> Great, normally we omit the "get" part in methods.
<slap type="forehead">Style Guidelines</slap> Thanks for the reminder.
labelForControl and controlForLabel it is. :-)
More information about the webkit-reviews
mailing list