[webkit-reviews] review denied: [Bug 27231] REGRESSION: Clicking on nodes in the console should take you to the element in the DOM : [Attachment 41584] proposed patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27231: REGRESSION: Clicking on nodes in the console should take you to the
element in the DOM
https://bugs.webkit.org/show_bug.cgi?id=27231

Attachment 41584: proposed patch
https://bugs.webkit.org/attachment.cgi?id=41584&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	   if (this.showInElementsPanel)

This can just be:

	   if (this.treeOutline.showInElementsPanelEnabled)

Then you don't need all the propagation code.

> +	       WebInspector.panels.elements.focusedDOMNode =
this.representedObject;

We should switch to the Elements panel if it isn't visible too.