[webkit-reviews] review denied: [Bug 30522] Web Inspector: DOM Exceptions throughout the Inspector should be more human readable : [Attachment 41451] Log the description when a DOM Exception is logged

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 10:43:41 PDT 2009


Eric Seidel <eric at webkit.org> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 30522: Web Inspector: DOM Exceptions throughout the Inspector should be
more human readable
https://bugs.webkit.org/show_bug.cgi?id=30522

Attachment 41451: Log the description when a DOM Exception is logged
https://bugs.webkit.org/attachment.cgi?id=41451&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems that this test would be clearer w/o using console.log.

Do you really want to log all of the constants on the exception, or are you
just trying to log the description?

A script-test may be a better choice for this style of test, since there you
could use "debug()" easily for printing like this.

Ideally a test should carry test expectations in it instead of just dumping
data, however that may not be possible/appropriate for this particular test.

Sad that Exceptions don't have any sort of base class.

Is "description" covered by any ECMA spec?

r- since the test is so hard to read with all the extra console.log linenumber
output.


More information about the webkit-reviews mailing list