[webkit-reviews] review denied: [Bug 30572] Unification of using null device in perl scripts : [Attachment 41507] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 10:37:37 PDT 2009

Eric Seidel <eric at webkit.org> has denied Csaba Osztrogonac <ossy at webkit.org>'s
request for review:
Bug 30572: Unification of using null device in perl scripts

Attachment 41507: proposed patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
I believe our style is to put spaces around '.' operators.

Also, I'm surprised that sometimes you use local variables to hold $devNull and
sometimes you make direct calls to File::Spec->devnull().

Is devnull() always a string path?

More information about the webkit-reviews mailing list