[webkit-reviews] review granted: [Bug 30631] Suppress unavoidable MSVC warnings during wxWebKit build : [Attachment 41564] Patch to disable several more MSVC warnings

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Vadim Zeitlin
<vz-webkit at zeitlins.org>'s request for review:
Bug 30631: Suppress unavoidable MSVC warnings during wxWebKit build
https://bugs.webkit.org/show_bug.cgi?id=30631

Attachment 41564: Patch to disable several more MSVC warnings
https://bugs.webkit.org/attachment.cgi?id=41564&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm glad to see these documented.  We're slowly getting rid of the struct/class
warnings.

Are you sure the rest of these should not be turned into bugs?	I think some of
these should be made into bugs and the bug numbers added as comments next to
those ignore lines.

I'm very very very glad that you're documenting the type of warning next to the
code.  That's much better than how the file looked previously.

Please strongly consider turning some of these into WebKit bugs and adding the
bug numbers to the settting.py comments as well.

If you want this committed by the commit-bot you'll need to set commit-queue=?