[webkit-reviews] review requested: [Bug 30631] Suppress unavoidable MSVC warnings during wxWebKit build : [Attachment 41564] Patch to disable several more MSVC warnings

[bugzilla-daemon at webkit.org]

Vadim Zeitlin <vz-webkit at zeitlins.org> has asked  for review:
Bug 30631: Suppress unavoidable MSVC warnings during wxWebKit build
https://bugs.webkit.org/show_bug.cgi?id=30631

Attachment 41564: Patch to disable several more MSVC warnings
https://bugs.webkit.org/attachment.cgi?id=41564&action=review

------- Additional Comments from Vadim Zeitlin <vz-webkit at zeitlins.org>
Currently building wxWebKit results in tons of output due to unimportant or
unavoidable MSVC warnings which prevent you from seeing any important ones.
Some of them were already disabled but I'd like to add a few more. Quoting the
attached patch:

Disable several warnings which occur many times during the build.
Some of them are harmless (4099, 4344, 4396, 4800) and working around
them in WebKit code is probably just not worth it. We can simply do
nothing about the others (4503). A couple are possibly valid but
there are just too many of them in the code so fixing them is
impossible in practice and just results in tons of distracting output
(4244, 4291). Finally 4996 is actively harmful as it is given for
just about any use of standard C/C++ library facilities.


TIA!