[webkit-reviews] review denied: [Bug 30621] Printing using other media types then "print" : [Attachment 41556] Media Type 1.0

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Jakob Truelsen
<antialize at gmail.com>'s request for review:
Bug 30621: Printing using other media types then "print"
https://bugs.webkit.org/show_bug.cgi?id=30621

Attachment 41556: Media Type 1.0
https://bugs.webkit.org/attachment.cgi?id=41556&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  void Frame::setPrinting(bool printing, float minPageWidth, float
maxPageWidth, bool adjustViewSize)
>  {
> +    String mediaType;
> +    if (m_page->settings())


Use:

     String mediaType = settings() ? settings()->printingMediaType() : "print";


reasoning:
     - m_page can be NULL... m_page->settings() not..
     - provide a default for printingMediaType as well..



> +*/
> +QString QWebSettings::printingMediaType() const
> +{
> +    return d->printingMediaType;
> +}

Which can be QString() which is not what your API doc said... have a default...
and let it be "print"

but in general this is a nice patch!