[webkit-reviews] review granted: [Bug 30437] Japanese Text Search Problem : [Attachment 41543] Revised patch 3

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Satoshi Nakagawa
<psychs at limechat.net>'s request for review:
Bug 30437: Japanese Text Search Problem
https://bugs.webkit.org/show_bug.cgi?id=30437

Attachment 41543: Revised patch 3
https://bugs.webkit.org/attachment.cgi?id=41543&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    UCollator* collator = ucol_openRules(japaneseKanaCollationRules, -1,
UCOL_DEFAULT, UCOL_DEFAULT_STRENGTH, 0, &status);
> +    ASSERT(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING ||
status == U_USING_DEFAULT_WARNING);

Are all three of these expected here for some reason, or are you just ignoring
the same set I ignored for usearch_open?

> +    usearch_setCollator(searcher, collator(), &status);
> +    ASSERT(status == U_ZERO_ERROR || status == U_USING_FALLBACK_WARNING ||
status == U_USING_DEFAULT_WARNING);

Same question.

r=me, but I would like to hear the answer to that question at some point.