[webkit-reviews] review requested: [Bug 19879] Inspector should support monitorEvents/un monitorEvents() in the command line : [Attachment 41545] proposed patch 2

[bugzilla-daemon at webkit.org]

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 19879: Inspector should support monitorEvents/un monitorEvents() in the
command line
https://bugs.webkit.org/show_bug.cgi?id=19879

Attachment 41545: proposed patch 2
https://bugs.webkit.org/attachment.cgi?id=41545&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
(In reply to comment #3)
> > +		     if (t[i] == \"mouse\") \
Fixed.
> > +			 te = te.concat([\"mousedown\", \"mouseup\", \"click\",
\"dblclick\", \
Fixed.
> > +		     if (t[i] == \"key\") \
Fixed.
> Should you test for addEventListener / removeEvent listener on an object?
Added tests.
> Does monitorEvent(null) provide meaningful feedback well?
I wasn't sure what to do. Should it print usage help or an error?